fix(http): set I/O timeout to 1 minute rather than whole request timeout #5916
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
commented
Aug 25, 2024
| // if request timeout is set to 5 minutes | ||
| // and connection timeout is set to 1 minute. | ||
| // | ||
| // We do not set write timeout because `reqwest` |
There was a problem hiding this comment.
For IMAP and SMTP we set both read and write timeout in connect_tcp_inner.
There was a problem hiding this comment.
I opened an issue about the lack of API to set write timeout: seanmonstar/reqwest#2403
We may also switch to using hyper directly and establishing connections manually in the future as we already have generic code to handle IMAP and SMTP connection attempts and TLS session establishment, but for now this minimal change is good enough to fix the bug and allow Delta Chat to test multiple IP addresses from DNS response.
Before the fix HTTP client had no connection timeout, so it only had a chance to test one IPv6 and one IPv4 address if the first addresses timed out. Now it can test at least 4 addresses of each family and more if some addresses refuse connection rather than time out.
link2xt
force-pushed
the
link2xt/http-timeout-fix
branch
from
4bb4dc4 to
1109d5a
Compare
iequidoo
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix HTTP client
had no connection timeout,
so it only had a chance
to test one IPv6 and one IPv4
address if the first addresses timed out.
Now it can test at least 4 addresses
of each family and more if some addresses
refuse connection rather than time out.